perf: Optimize page loading #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
TagStudio: Search
CyanVoxel
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
I apologize for the big delay on getting to reviewing this.
Overall this seems to be a great improvement! We've been wanting to move (back) to referencing entries by ID ever since the change came into play in 9.5.
I'll go ahead and tidy up the merge conflict and get this merged. Thank you so much for your work on this!
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change
search_libraryto only fetchentry.id.Add
get_tag_entriesmethod to Library. Returns adict[tag_id, set[entry_ids]]Change
update_thumbsto not fetch all tags for entries on page and instead use the above method to only check the tags it cares about.move signal connection for
item_thumbout ofupdate_thumbsand into its init method.This brings page load from 200ms->4ms
Tasks Completed